CMCL-1631: FramingTransposer with a dead zone would sometimes drift#1031
Merged
CMCL-1631: FramingTransposer with a dead zone would sometimes drift#1031
Conversation
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1031 +/- ##
==========================================
+ Coverage 26.97% 27.21% +0.24%
==========================================
Files 254 254
Lines 28418 28485 +67
==========================================
+ Hits 7665 7753 +88
+ Misses 20753 20732 -21 ☔ View full report in Codecov by Sentry. |
alexzaranek
approved these changes
Jan 7, 2025
Contributor
alexzaranek
left a comment
alexzaranek
left a comment
There was a problem hiding this comment.
Tested the changes and the drift is gone 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
CMCL-1631: FramingTransposer camera drift when nonzero dead zone.
Fix was to improve precision of calculation.
Testing status
Documentation status
Technical risk
low